forked from bitcoinjs/bitcoinjs-lib
-
Notifications
You must be signed in to change notification settings - Fork 0
WIP: p2tr_ns #6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
brandonblack
wants to merge
74
commits into
bitcoincoretech:p2tr-v1
Choose a base branch
from
BitGo:p2tr-v1
base: p2tr-v1
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
WIP: p2tr_ns #6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- add `internalPubkey` and `redeems` fields - add some temp comments
…wn and script path is not used
… hash from the taproot tree
…t` to `rootHashFromTree`
…`fromOutputScript`)
* test: add PSBT example for taproot * refactor: variable renaming * refactor: use constant for tapscript leaf version * feat: reuse redeem field for taproot spend * test: make sure it defaults to tapscript version 192 * chore: remove `scriptLeaf` logic * feat: add tapscript sign() a finalize() logic * test: spend taproot script-path * test: add tapscript for OP_CHECKSEQUENCEVERIFY * feat: add multisig integration test * refactor: rename scriptsTree to scriptTree (as per BP341) * feat: check that the scriptTree is a binary tree * feat: compute the redeem from witness; add unit tests * test: add test for invalid redeem script * feat: check the redeemVersion on the input data first * test: add tests for taproot script-path sign, and key-path finalize
…ipt` param to the end
* Move the (much simplified) type check function to types.ts * Use `Tapleaf` type a bit more (this might be a bad idea) * Be more consistent in the capitalization of `Taptree`
Because the taggedHash API is typed, these are compile-time checked and it's more clear w/o the constants.
* More clearly show the continuation and base cases in findScriptPath * Return undefined not empty path when no path is found * This would lead to generating an invalid witness * Tighten the type for HashTree to not allow 1-sided branch nodes
* Also added caching of `hashTree`, per todo. * Added a test for this functionality
The spec uses this notation because in a spec there's no such thing as reassigning a value. In real code it is appropriate to us accumulators or such.
* refactor: explicit initialization on the ecc library - remove optional `eccLib` parameter for `p2tr` and `psbt`
bd12ee6
to
79d14a7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.